Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument Playing Previous Sound #76

Closed
ghana7989 opened this issue May 16, 2021 · 1 comment · Fixed by #80
Closed

Instrument Playing Previous Sound #76

ghana7989 opened this issue May 16, 2021 · 1 comment · Fixed by #80

Comments

@ghana7989
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '{URL}/edit'
  2. Click on 'InstrumentBrowser Button'
  3. Keep changing instruments.
  4. See error

Expected behavior
When clicked on instrument it should play it's own sound, Instead It is playing previously selected sound

Desktop (please complete the following information):

  • OS: Windows
  • Browser Brave

Additional context
I tried to debug I found what is causing it but could not fix it. when click on instrument it is getting stored in the store but the component is not getting updated after that.
@ryohey ryohey mentioned this issue Jun 16, 2021
Merged
@ryohey
Copy link
Owner

ryohey commented Jun 16, 2021

Thank you for your report!
I found that Player sends set program event after note on event.
This is fixed in #76

@ryohey ryohey closed this as completed Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix playing previous instrument ryohey/signal
2 participants
@ryohey @ghana7989