Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scrolling past the playhead while the song is playing #354

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abaresk
Copy link
Collaborator

@abaresk abaresk commented May 23, 2024

Before this change, the editor prevented you from scrolling the playhead off-screen if autoScroll was enabled and the song was playing. Now you can scroll as far as you want while the song is playing.

If you scroll sufficiently far, autoScroll will become unset. You can jump back to the current playhead position by turning autoScroll back on.

Copy link

vercel bot commented May 23, 2024

@abaresk is attempting to deploy a commit to the Ryohei Kameyama's projects Team on Vercel.

A member of the Team first needs to authorize it.

@abaresk abaresk marked this pull request as draft May 23, 2024 16:47
@abaresk abaresk marked this pull request as ready for review May 24, 2024 05:32
Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
signal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 2:11am

@ryohey
Copy link
Owner

ryohey commented May 29, 2024

Thank you for your suggestion. Very smart, but may confuse users. Simple and consistent behavior is preferred. How about simply disabling autoScroll when the scrollbar is moved?

<HorizontalScaleScrollBar
  scrollOffset={scrollLeft}
  contentLength={contentWidth}
  onScroll={useCallback((v: any) => {
    s.setScrollLeftInPixels(v)
    s.autoScroll = false
  }, [s])}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants