Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vacuum: return None for is_water_box_attached when unsupported #1168

Closed
rytilahti opened this issue Oct 29, 2021 · 0 comments · Fixed by #1178
Closed

vacuum: return None for is_water_box_attached when unsupported #1168

rytilahti opened this issue Oct 29, 2021 · 0 comments · Fixed by #1178
Labels
bug

Comments

@rytilahti
Copy link
Owner

Describe the bug

is_water_box_attached incorrectly returns a boolean on non-supported devices: https://github.com/rytilahti/python-miio/blob/master/miio/vacuumcontainers.py#L189

Thanks to @OGKevin for spotting this at home-assistant/core#57553 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vacuum: return none on is_water_box_attached if unsupported rytilahti/python-miio
1 participant
@rytilahti