Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vacuum: return none on is_water_box_attached if unsupported #1178

Merged
merged 1 commit into from Nov 3, 2021

Conversation

rytilahti
Copy link
Owner

Fixes #1168

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021

Codecov Report

Merging #1178 (e2542e2) into master (506247e) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1178      +/-   ##
==========================================
- Coverage   78.30%   78.28%   -0.02%     
==========================================
  Files          84       84              
  Lines        9518     9520       +2     
  Branches      775      776       +1     
==========================================
  Hits         7453     7453              
- Misses       1879     1880       +1     
- Partials      186      187       +1     
Impacted Files Coverage Δ
...o/integrations/vacuum/roborock/vacuumcontainers.py 76.70% <50.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506247e...e2542e2. Read the comment docs.

@rytilahti rytilahti changed the title vacuum: return none if water_box_status is not supported vacuum: return none on is_water_box_attached if unsupported Nov 3, 2021
@rytilahti rytilahti merged commit 9b099b5 into master Nov 3, 2021
@rytilahti rytilahti deleted the vacuum/fix/waterbox_attached branch November 3, 2021 00:59
@rytilahti rytilahti mentioned this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vacuum: return None for is_water_box_attached when unsupported
2 participants