increase socket buffer size 1024->4096 #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a gateway has 30+ devices connected the message of the device list becomes bigger than 1024 bytes. That means only part of the message is read, and therefore the checksum will not match and you get an error. simply increasing the buffer size fixed this issue. See home-assistant/core#51229
Codecov Report
@@ Coverage Diff @@
## master #1075 +/- ##
=======================================
Coverage 75.40% 75.40%
=======================================
Files 73 73
Lines 8367 8367
Branches 745 745
=======================================
Hits 6309 6309
Misses 1874 1874
Partials 184 184
Continue to review full report at Codecov.
|
|
@rytilahti could you merge this extremely small PR? |
|
Good catch! LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a gateway has 30+ devices connected the message of the device list becomes bigger than 1024 bytes.
That means only part of the message is read, and therefore the checksum will not match and you get an error.
simply increasing the buffer size fixed this issue.
See home-assistant/core#51229