Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set_rotate for dmaker.fan.p10 (#1076) #1078

Merged
merged 4 commits into from
Jun 24, 2021

Conversation

pooyashahidi
Copy link
Contributor

@pooyashahidi pooyashahidi commented Jun 20, 2021

A suggestion to fix rotation command for P9,P10,P11,P15,P18,...
fixes issue #1076

@rytilahti rytilahti added the bug label Jun 24, 2021
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM, but could you please add a docstring to the method while you are at it?

miio/fan_miot.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021

Codecov Report

Merging #1078 (c2ba250) into master (ac02020) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1078      +/-   ##
==========================================
- Coverage   75.47%   75.43%   -0.05%     
==========================================
  Files          74       74              
  Lines        8367     8372       +5     
  Branches      741      743       +2     
==========================================
  Hits         6315     6315              
- Misses       1870     1875       +5     
  Partials      182      182              
Impacted Files Coverage Δ
miio/fan_miot.py 88.04% <0.00%> (-2.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac02020...c2ba250. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants