Add support for Smartmi Standing Fan 3 (zhimi.fan.za5) #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnovatorov
force-pushed
the
zhimi-fan-za5
branch
from
7629b45
to
745c188
Compare
Codecov Report
@@ Coverage Diff @@
## master #1087 +/- ##
==========================================
+ Coverage 76.04% 76.08% +0.03%
==========================================
Files 75 75
Lines 8730 8847 +117
Branches 748 759 +11
==========================================
+ Hits 6639 6731 +92
- Misses 1909 1930 +21
- Partials 182 186 +4
Continue to review full report at Codecov.
|
|
Tested locally as well - works great! 👏🏻 |
rytilahti
reviewed
Aug 1, 2021
There was a problem hiding this comment.
Thanks for the PR @rnovatorov! I added a couple of comments inline, could you also add some tests to make coverage checks happy? :-)
rnovatorov
force-pushed
the
zhimi-fan-za5
branch
6 times, most recently
from
4757f77
to
75e6568
Compare
rytilahti
reviewed
Aug 15, 2021
There was a problem hiding this comment.
I have checked the properties of the other fans and adapted some of the new methods to be similar to the existing ones. If you think that additional changes are required, then could you, please, be more specific about which properties you would like me to edit and how?
I think it's fine, just add tests and we will consolidate it when there will be a common fan base class (#1114 lists some of the upcoming changes to make it easier to interact).
rnovatorov
force-pushed
the
zhimi-fan-za5
branch
3 times, most recently
from
a784dab
to
9edd995
Compare
|
Added the tests. I guess everything is ready now. |
rytilahti
reviewed
Aug 15, 2021
rnovatorov
force-pushed
the
zhimi-fan-za5
branch
from
9edd995
to
ad2fbd5
Compare
|
Fixed the minor things. Mentioned the device in |
rytilahti
approved these changes
Aug 15, 2021
rytilahti
added a commit
that referenced
this pull request
Sep 1, 2021
* Fix usage of deprecated depth for airhumidifer [Full Changelog](0.5.7...0.5.8) **Implemented enhancements:** - vacuum: skip timezone call if there are no timers [\#1122](#1122) ([rytilahti](https://github.com/rytilahti)) **Closed issues:** - Smart Mi Standing fan 3 \(Xiaomi Pedestal Fan 3, zhimi.fan.za5\) [\#788](#788) **Merged pull requests:** - readme: add micloudfaker to list of related projects [\#1127](#1127) ([unrelentingtech](https://github.com/unrelentingtech)) - Update readme with section for related projects [\#1126](#1126) ([rytilahti](https://github.com/rytilahti)) - add lumi.plug.mmeu01 - ZNCZ04LM [\#1125](#1125) ([starkillerOG](https://github.com/starkillerOG)) - Do not use deprecated `depth` property [\#1124](#1124) ([bieniu](https://github.com/bieniu)) - vacuum: remove long-deprecated 'return\_list' for clean\_details [\#1123](#1123) ([rytilahti](https://github.com/rytilahti)) - deprecate Fan{V2,SA1,ZA1,ZA3,ZA4} in favor of model kwarg [\#1119](#1119) ([rytilahti](https://github.com/rytilahti)) - Add support for Smartmi Standing Fan 3 \(zhimi.fan.za5\) [\#1087](#1087) ([rnovatorov](https://github.com/rnovatorov))
Merged
rytilahti
added a commit
that referenced
this pull request
Sep 1, 2021
* Add support for smart mi standing fan 3 (zhimi.fan.za5) * Fix usage of deprecated depth for airhumidifer [Full Changelog](0.5.7...0.5.8) **Implemented enhancements:** - vacuum: skip timezone call if there are no timers [\#1122](#1122) ([rytilahti](https://github.com/rytilahti)) **Closed issues:** - Smart Mi Standing fan 3 \(Xiaomi Pedestal Fan 3, zhimi.fan.za5\) [\#788](#788) **Merged pull requests:** - readme: add micloudfaker to list of related projects [\#1127](#1127) ([unrelentingtech](https://github.com/unrelentingtech)) - Update readme with section for related projects [\#1126](#1126) ([rytilahti](https://github.com/rytilahti)) - add lumi.plug.mmeu01 - ZNCZ04LM [\#1125](#1125) ([starkillerOG](https://github.com/starkillerOG)) - Do not use deprecated `depth` property [\#1124](#1124) ([bieniu](https://github.com/bieniu)) - vacuum: remove long-deprecated 'return\_list' for clean\_details [\#1123](#1123) ([rytilahti](https://github.com/rytilahti)) - deprecate Fan{V2,SA1,ZA1,ZA3,ZA4} in favor of model kwarg [\#1119](#1119) ([rytilahti](https://github.com/rytilahti)) - Add support for Smartmi Standing Fan 3 \(zhimi.fan.za5\) [\#1087](#1087) ([rnovatorov](https://github.com/rnovatorov))
rytilahti
added a commit
that referenced
this pull request
Sep 1, 2021
* Add support for smart mi standing fan 3 (zhimi.fan.za5) * Fix usage of deprecated depth for airhumidifer [Full Changelog](0.5.7...0.5.8) **Implemented enhancements:** - vacuum: skip timezone call if there are no timers [\#1122](#1122) ([rytilahti](https://github.com/rytilahti)) **Closed issues:** - Smart Mi Standing fan 3 \(Xiaomi Pedestal Fan 3, zhimi.fan.za5\) [\#788](#788) **Merged pull requests:** - readme: add micloudfaker to list of related projects [\#1127](#1127) ([unrelentingtech](https://github.com/unrelentingtech)) - Update readme with section for related projects [\#1126](#1126) ([rytilahti](https://github.com/rytilahti)) - add lumi.plug.mmeu01 - ZNCZ04LM [\#1125](#1125) ([starkillerOG](https://github.com/starkillerOG)) - Do not use deprecated `depth` property [\#1124](#1124) ([bieniu](https://github.com/bieniu)) - vacuum: remove long-deprecated 'return\_list' for clean\_details [\#1123](#1123) ([rytilahti](https://github.com/rytilahti)) - deprecate Fan{V2,SA1,ZA1,ZA3,ZA4} in favor of model kwarg [\#1119](#1119) ([rytilahti](https://github.com/rytilahti)) - Add support for Smartmi Standing Fan 3 \(zhimi.fan.za5\) [\#1087](#1087) ([rnovatorov](https://github.com/rnovatorov))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #788.