Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add water_level and water_tank_detached property for humidifiers, deprecate depth #1089

Merged
merged 6 commits into from Jul 7, 2021
Merged

Add water_level and water_tank_detached property for humidifiers, deprecate depth #1089

merged 6 commits into from Jul 7, 2021

Conversation

bieniu
Copy link
Contributor

@bieniu bieniu commented Jun 28, 2021

This PR:

  • adds water_level property for AirHumidifier (value is calculated from depth)
  • adds water_tank_detached for AirHumidifier (value is calculated from depth)
  • fixes water_level calculation for AirHumidifierMiot
  • adds water_tank_detached for AirHumidifierMiot (value is calculated from water_level)

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #1089 (d31b8e8) into master (b9393f3) will increase coverage by 0.02%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1089      +/-   ##
==========================================
+ Coverage   75.43%   75.45%   +0.02%     
==========================================
  Files          74       74              
  Lines        8372     8386      +14     
  Branches      743      745       +2     
==========================================
+ Hits         6315     6328      +13     
- Misses       1875     1876       +1     
  Partials      182      182              
Impacted Files Coverage Δ
miio/airhumidifier_miot.py 82.89% <71.42%> (-0.78%) ⬇️
miio/airhumidifier.py 87.56% <100.00%> (+1.62%) ⬆️
miio/deviceinfo.py 80.64% <0.00%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9393f3...d31b8e8. Read the comment docs.

miio/airhumidifier.py Outdated Show resolved Hide resolved
@rytilahti rytilahti changed the title Unify water_level property for humidifiers Add water_level and water_tank_detached property for humidifiers, deprecate depth Jul 7, 2021
@rytilahti rytilahti merged commit 83cd097 into rytilahti:master Jul 7, 2021
@bieniu bieniu deleted the clean-water-level branch July 7, 2021 20:46
@bieniu
Copy link
Contributor Author

bieniu commented Aug 1, 2021

@rytilahti Are you planning to release a new version? The migration of humidifiers from the fan platform to the humidifier in HA was merged and now we need water_level property 😁

@rytilahti
Copy link
Owner

Yes, I'll prepare a new release when I return from the holidays (i.e., there should be a new release available in a couple of weeks), if @syssi doesn't beat me with that. Sorry for the delay :/

@bieniu
Copy link
Contributor Author

bieniu commented Aug 2, 2021

Sorry for the delay :/

No problem, enjoy the holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants