Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional OperatingModes and FaultStatuses for dreamevacuum #1090

Merged
merged 7 commits into from Jul 8, 2021
Merged

Added additional OperatingModes and FaultStatuses for dreamevacuum #1090

merged 7 commits into from Jul 8, 2021

Conversation

StarterCraft
Copy link
Contributor

@StarterCraft StarterCraft commented Jun 30, 2021

SKV4093GL (aka STYTJ01ZHM aka dreame.vacuum.mc1808)

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! A couple of very minor changes needed but then this is good to go.

miio/dreamevacuum_miot.py Outdated Show resolved Hide resolved
miio/dreamevacuum_miot.py Outdated Show resolved Hide resolved
miio/dreamevacuum_miot.py Outdated Show resolved Hide resolved
miio/dreamevacuum_miot.py Outdated Show resolved Hide resolved
@StarterCraft
Copy link
Contributor Author

Fixes were made, please review!

miio/dreamevacuum_miot.py Outdated Show resolved Hide resolved
@rytilahti
Copy link
Owner

Can be merged as soon as the checks pass. Please run pre-commit run -a to fix it.

@StarterCraft
Copy link
Contributor Author

In which catalog should I run this command?

@rytilahti
Copy link
Owner

On your local git checkout. As it's only a single whitespace case, you can also fix it online on github by adding a single space here:

-       #TODO: MiotDevice class should have a possibility to define its max_properties value
+        #TODO: MiotDevice class should have a possibility to define its max_properties value

@StarterCraft
Copy link
Contributor Author

Like that?

miio/dreamevacuum_miot.py Outdated Show resolved Hide resolved
@rytilahti
Copy link
Owner

I cleaned up the code a bit (that method is not needed in the dreame class as it exists already in master), that will also solve the linting problem I hope :-)

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021

Codecov Report

Merging #1090 (c058082) into master (b9393f3) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1090      +/-   ##
==========================================
+ Coverage   75.43%   75.49%   +0.06%     
==========================================
  Files          74       74              
  Lines        8372     8389      +17     
  Branches      743      744       +1     
==========================================
+ Hits         6315     6333      +18     
+ Misses       1875     1874       -1     
  Partials      182      182              
Impacted Files Coverage Δ
miio/dreamevacuum_miot.py 83.54% <100.00%> (+1.60%) ⬆️
miio/deviceinfo.py 80.64% <0.00%> (-3.23%) ⬇️
miio/airhumidifier_miot.py 82.89% <0.00%> (-0.78%) ⬇️
miio/airhumidifier.py 87.56% <0.00%> (+1.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9393f3...c058082. Read the comment docs.

@rytilahti rytilahti changed the title Added additional OperatingMode and DeviceStatus codes for SKV4093GL (aka STYTJ01ZHM aka dreame.vacuum.mc1808) Added additional OperatingModes and FaultStatuses for dreame_vacuum Jul 8, 2021
@rytilahti rytilahti changed the title Added additional OperatingModes and FaultStatuses for dreame_vacuum Added additional OperatingModes and FaultStatuses for dreamevacuum Jul 8, 2021
@StarterCraft
Copy link
Contributor Author

OK, will you finally merge this?

@rytilahti
Copy link
Owner

Let's merge it, thanks for the PR @StarterCraft! 🎉

@rytilahti rytilahti merged commit 61ca4a1 into rytilahti:master Jul 8, 2021
@StarterCraft StarterCraft deleted the patch-1 branch July 8, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants