Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cli work again for offline gen1 vacs, fix tests #1141

Merged
merged 4 commits into from Sep 17, 2021

Conversation

rytilahti
Copy link
Owner

@rytilahti rytilahti commented Sep 17, 2021

  • Vacuum overrides now the internal _fetch_info
  • Fix tests for new integrations that were assigning now-readonly model

@rytilahti rytilahti changed the title Make cli tools work again for offline gen1 vacs Make cli work again for offline gen1 vacs, fix tests Sep 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2021

Codecov Report

Merging #1141 (4e8eb85) into master (75ac5fd) will decrease coverage by 0.59%.
The diff coverage is 25.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1141      +/-   ##
==========================================
- Coverage   76.08%   75.48%   -0.60%     
==========================================
  Files          75       76       +1     
  Lines        8847     8975     +128     
  Branches      759      750       -9     
==========================================
+ Hits         6731     6775      +44     
- Misses       1930     2018      +88     
+ Partials      186      182       -4     
Impacted Files Coverage Δ
miio/airconditioningcompanion.py 96.46% <0.00%> (+0.96%) ⬆️
miio/airdehumidifier.py 84.09% <0.00%> (+1.86%) ⬆️
miio/airfresh.py 90.25% <0.00%> (+1.72%) ⬆️
miio/airfresh_t2017.py 95.06% <0.00%> (+3.39%) ⬆️
miio/airhumidifier_jsq.py 92.45% <0.00%> (-0.89%) ⬇️
miio/airhumidifier_mjjsq.py 92.30% <0.00%> (+2.94%) ⬆️
miio/airpurifier_airdog.py 91.20% <0.00%> (+8.20%) ⬆️
miio/airqualitymonitor.py 81.66% <0.00%> (+4.50%) ⬆️
miio/chuangmi_plug.py 87.75% <0.00%> (ø)
miio/fan_leshow.py 94.87% <0.00%> (+3.51%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a344f...4e8eb85. Read the comment docs.

@rytilahti rytilahti merged commit 0e7a31e into master Sep 17, 2021
@rytilahti rytilahti deleted the fix/mirobo_for_v1 branch September 17, 2021 11:56
@rytilahti rytilahti added the bug label Nov 30, 2021
@rytilahti rytilahti mentioned this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants