New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create separate directory for yeelight #1160
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1160 +/- ##
==========================================
+ Coverage 76.10% 76.61% +0.50%
==========================================
Files 76 77 +1
Lines 8927 9155 +228
Branches 750 756 +6
==========================================
+ Hits 6794 7014 +220
- Misses 1950 1958 +8
Partials 183 183
Continue to review full report at Codecov.
|
@rytilahti Did I do this correct? Could you provide what else I must change? Maybe move test some how. |
Looking good, but yeah, the test should also be moved under |
@rytilahti Look to new commit please. Locally test start |
@Kirmas the integrations should be inside the miio package so that it will be accessible so I changed that. Now running |
Funny misunderstanding. Is this PR is Ok now? I really want add spec file in the new one. To do this step by step. |
Yes, I think we can merge this now. Thanks for the PR and pushing this onward :-) |
Based on #1094 (review) but I believe the "moving" PR could be separate. This PR only move the yeelight code to the folder. Next PR will be soon.
@rytilahti could you merge this one?