Move vacuums to self-contained integrations #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1165 +/- ##
==========================================
+ Coverage 77.91% 78.30% +0.38%
==========================================
Files 79 84 +5
Lines 9220 9518 +298
Branches 761 775 +14
==========================================
+ Hits 7184 7453 +269
- Misses 1852 1879 +27
- Partials 184 186 +2
Continue to review full report at Codecov.
|
rytilahti
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integrations are to be stored under a category of devices it belongs to, the idea being that there will be category-specific common interfaces to simplify downstream implementations:
vacuum*.py=>miio/integrations/vacuum/roborock/dreamevacuum_miot.py=>miio/integrations/vacuum/dreame/roidmivacuum_miot.py=>miio/integrations/vacuum/roidmi/viomivacuum.py=>miio/integrations/vacuum/viomi/For the time being, the already exported implementations remain accessible via miio module, but this is expected to change in the future when common, category specific interfaces are introduced.