Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow publish on test pypi workflow to fail #1177

Merged
merged 1 commit into from Nov 3, 2021

Conversation

rytilahti
Copy link
Owner

A stop-gap solution to avoid all merges on master to fail just because a testpypi release already exists.

Something like https://github.com/pypa/setuptools_scm should probably used instead, and the real releases should be made on github releases and not on tags..

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021

Codecov Report

Merging #1177 (0b97e9e) into master (402bed6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1177   +/-   ##
=======================================
  Coverage   78.30%   78.30%           
=======================================
  Files          84       84           
  Lines        9518     9518           
  Branches      775      775           
=======================================
  Hits         7453     7453           
  Misses       1879     1879           
  Partials      186      186           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 402bed6...0b97e9e. Read the comment docs.

@rytilahti rytilahti merged commit 506247e into master Nov 3, 2021
@rytilahti rytilahti deleted the janitor/allow_pypi_release_fail branch November 3, 2021 00:27
@rytilahti rytilahti changed the title Allow failure to publish on test pypi Allow publish on test pypi workflow to fail Nov 3, 2021
@rytilahti rytilahti mentioned this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants