Add more supported devices to their corresponding classes #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1237 +/- ##
==========================================
+ Coverage 79.28% 79.29% +0.01%
==========================================
Files 90 90
Lines 9731 9737 +6
Branches 1130 1130
==========================================
+ Hits 7715 7721 +6
Misses 1824 1824
Partials 192 192
Continue to review full report at Codecov.
|
This was referenced Dec 13, 2021
… from homeassistant
…t to it if no model is given
rytilahti
force-pushed
the
fix/more_supported_devices
branch
from
c879c6d
to
36b0665
Compare
|
I'll merge this now to make it easier to test, further additions are to be done in separate PR(s). |
This was referenced Dec 13, 2021
Closed
rytilahti
added a commit
that referenced
this pull request
Dec 14, 2021
This release fixes regressions caused by the recent refactoring related to supported models: * philips_bulb now defaults to a bulb that has color temperature setting * gateway devices do not perform an info query as that is handled by their parent Also, the list of the supported models was extended thanks to the feedback from the community! [Full Changelog](0.5.9.1...0.5.9.2) **Implemented enhancements:** - Add yeelink.bhf\_light.v2 and yeelink.light.lamp22 support [\#1250](#1250) ([FaintGhost](https://github.com/FaintGhost)) - Skip warning if the unknown model is reported on a base class [\#1243](#1243) ([rytilahti](https://github.com/rytilahti)) - Add emptying bin status for roborock s7+ [\#1190](#1190) ([rytilahti](https://github.com/rytilahti)) **Fixed bugs:** - Fix Roborock S7 fan speed [\#1235](#1235) ([shred86](https://github.com/shred86)) - gateway: remove click support for gateway devices [\#1229](#1229) ([starkillerOG](https://github.com/starkillerOG)) - mirobo: make sure config always exists [\#1207](#1207) ([rytilahti](https://github.com/rytilahti)) - Fix typo [\#1204](#1204) ([com30n](https://github.com/com30n)) **Merged pull requests:** - philips\_eyecare: add philips.light.sread1 as supported [\#1246](#1246) ([rytilahti](https://github.com/rytilahti)) - Add yeelink.light.color3 support [\#1245](#1245) ([Kirmas](https://github.com/Kirmas)) - Use codecov-action@v2 for CI [\#1244](#1244) ([rytilahti](https://github.com/rytilahti)) - Add yeelink.light.color5 support [\#1242](#1242) ([Kirmas](https://github.com/Kirmas)) - Add more supported devices to their corresponding classes [\#1237](#1237) ([rytilahti](https://github.com/rytilahti)) - Add zhimi.humidfier.ca4 as supported model [\#1220](#1220) ([jbouwh](https://github.com/jbouwh)) - vacuum: Add t7s \(roborock.vacuum.a14\) [\#1214](#1214) ([rytilahti](https://github.com/rytilahti)) - philips\_bulb: add philips.light.downlight to supported devices [\#1212](#1212) ([rytilahti](https://github.com/rytilahti))
Merged
rytilahti
added a commit
that referenced
this pull request
Dec 14, 2021
This release fixes regressions caused by the recent refactoring related to supported models: * philips_bulb now defaults to a bulb that has color temperature setting * gateway devices do not perform an info query as that is handled by their parent Also, the list of the supported models was extended thanks to the feedback from the community! [Full Changelog](0.5.9.1...0.5.9.2) **Implemented enhancements:** - Add yeelink.bhf\_light.v2 and yeelink.light.lamp22 support [\#1250](#1250) ([FaintGhost](https://github.com/FaintGhost)) - Skip warning if the unknown model is reported on a base class [\#1243](#1243) ([rytilahti](https://github.com/rytilahti)) - Add emptying bin status for roborock s7+ [\#1190](#1190) ([rytilahti](https://github.com/rytilahti)) **Fixed bugs:** - Fix Roborock S7 fan speed [\#1235](#1235) ([shred86](https://github.com/shred86)) - gateway: remove click support for gateway devices [\#1229](#1229) ([starkillerOG](https://github.com/starkillerOG)) - mirobo: make sure config always exists [\#1207](#1207) ([rytilahti](https://github.com/rytilahti)) - Fix typo [\#1204](#1204) ([com30n](https://github.com/com30n)) **Merged pull requests:** - philips\_eyecare: add philips.light.sread1 as supported [\#1246](#1246) ([rytilahti](https://github.com/rytilahti)) - Add yeelink.light.color3 support [\#1245](#1245) ([Kirmas](https://github.com/Kirmas)) - Use codecov-action@v2 for CI [\#1244](#1244) ([rytilahti](https://github.com/rytilahti)) - Add yeelink.light.color5 support [\#1242](#1242) ([Kirmas](https://github.com/Kirmas)) - Add more supported devices to their corresponding classes [\#1237](#1237) ([rytilahti](https://github.com/rytilahti)) - Add zhimi.humidfier.ca4 as supported model [\#1220](#1220) ([jbouwh](https://github.com/jbouwh)) - vacuum: Add t7s \(roborock.vacuum.a14\) [\#1214](#1214) ([rytilahti](https://github.com/rytilahti)) - philips\_bulb: add philips.light.downlight to supported devices [\#1212](#1212) ([rytilahti](https://github.com/rytilahti))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on issue reports & on homeassistant's manually constructed list of models.
I leave this PR open for a while as more models are likely to be reported in the upcoming days.
This also changes the default properties to be requested for philips_bulb to have the color temperature, as only a single model is currently known to use different, white-only properties. @syssi do you have any philips bulbs and could you give a test if this fixes home-assistant/core#61523 for good?
Fixes #1227 fixes #1234 fixes #1231 fixes #1241 fixes #1237 fixes #1239