Unit tests for philips lights #133

syssi · 2017-11-26T18:31:36Z

No description provided.

houndci-bot · 2017-11-26T18:31:44Z

miio/tests/test_philips_eyecare.py

+        self.device.ambient_on()
+        assert ambient() == True
+        self.device.ambient_off()
+        assert ambient() == False


comparison to False should be 'if cond is False:' or 'if not cond:'

houndci-bot · 2017-11-26T18:31:44Z

miio/tests/test_philips_eyecare.py

+            return self.device.status().ambient
+
+        self.device.ambient_on()
+        assert ambient() == True


comparison to True should be 'if cond is True:' or 'if cond:'

houndci-bot · 2017-11-26T18:31:44Z

miio/tests/test_philips_eyecare.py

+        self.device.reminder_on()
+        assert reminder() == True
+        self.device.reminder_off()
+        assert reminder() == False


comparison to False should be 'if cond is False:' or 'if not cond:'

houndci-bot · 2017-11-26T18:31:44Z

miio/tests/test_philips_eyecare.py

+            return self.device.status().reminder
+
+        self.device.reminder_on()
+        assert reminder() == True


comparison to True should be 'if cond is True:' or 'if cond:'

houndci-bot · 2017-11-26T18:31:44Z

miio/tests/test_philips_eyecare.py

+        self.device.smart_night_light_on()
+        assert smart_night_light() == True
+        self.device.smart_night_light_off()
+        assert smart_night_light() == False


comparison to False should be 'if cond is False:' or 'if not cond:'

houndci-bot · 2017-11-26T18:31:45Z

miio/tests/test_philips_eyecare.py

+        assert self.state().brightness == self.device.start_state["bright"]
+        assert self.state().reminder == (self.device.start_state["notifystatus"] == 'on')
+        assert self.state().ambient == (self.device.start_state["ambstatus"] == 'on')
+        assert self.state().ambient_brightness == self.device.start_state["ambvalue"]


line too long (85 > 79 characters)

houndci-bot · 2017-11-26T18:31:45Z

miio/tests/test_philips_eyecare.py

+        assert self.is_on() is True
+        assert self.state().brightness == self.device.start_state["bright"]
+        assert self.state().reminder == (self.device.start_state["notifystatus"] == 'on')
+        assert self.state().ambient == (self.device.start_state["ambstatus"] == 'on')


line too long (85 > 79 characters)

houndci-bot · 2017-11-26T18:31:45Z

miio/tests/test_philips_eyecare.py

+
+        assert self.is_on() is True
+        assert self.state().brightness == self.device.start_state["bright"]
+        assert self.state().reminder == (self.device.start_state["notifystatus"] == 'on')


line too long (89 > 79 characters)

houndci-bot · 2017-11-26T18:31:45Z

miio/tests/test_philips_bulb.py

+        self.device._reset_state()
+
+        assert self.is_on() is True
+


blank line at end of file

houndci-bot · 2017-11-26T18:31:45Z

miio/tests/test_ceil.py

+        self.device._reset_state()
+
+        assert self.is_on() is True
+


blank line at end of file

houndci-bot · 2017-11-26T18:31:46Z

miio/tests/test_philips_eyecare.py

+        self.device.ambient_on()
+        assert ambient() == True
+        self.device.ambient_off()
+        assert ambient() == False


comparison to False should be 'if cond is False:' or 'if not cond:'

houndci-bot · 2017-11-26T18:31:46Z

miio/tests/test_philips_eyecare.py

+            return self.device.status().ambient
+
+        self.device.ambient_on()
+        assert ambient() == True


comparison to True should be 'if cond is True:' or 'if cond:'

houndci-bot · 2017-11-26T18:31:46Z

miio/tests/test_philips_eyecare.py

+        self.device.reminder_on()
+        assert reminder() == True
+        self.device.reminder_off()
+        assert reminder() == False


comparison to False should be 'if cond is False:' or 'if not cond:'

houndci-bot · 2017-11-26T18:31:46Z

miio/tests/test_philips_eyecare.py

+            return self.device.status().reminder
+
+        self.device.reminder_on()
+        assert reminder() == True


comparison to True should be 'if cond is True:' or 'if cond:'

houndci-bot · 2017-11-26T18:31:46Z

miio/tests/test_philips_eyecare.py

+        self.device.smart_night_light_on()
+        assert smart_night_light() == True
+        self.device.smart_night_light_off()
+        assert smart_night_light() == False


comparison to False should be 'if cond is False:' or 'if not cond:'

houndci-bot · 2017-11-26T18:31:47Z

miio/tests/test_philips_eyecare.py

+        assert self.state().brightness == self.device.start_state["bright"]
+        assert self.state().reminder == (self.device.start_state["notifystatus"] == 'on')
+        assert self.state().ambient == (self.device.start_state["ambstatus"] == 'on')
+        assert self.state().ambient_brightness == self.device.start_state["ambvalue"]


line too long (85 > 79 characters)

houndci-bot · 2017-11-26T18:31:47Z

miio/tests/test_philips_eyecare.py

+        assert self.is_on() is True
+        assert self.state().brightness == self.device.start_state["bright"]
+        assert self.state().reminder == (self.device.start_state["notifystatus"] == 'on')
+        assert self.state().ambient == (self.device.start_state["ambstatus"] == 'on')


line too long (85 > 79 characters)

houndci-bot · 2017-11-26T18:31:47Z

miio/tests/test_philips_eyecare.py

+
+        assert self.is_on() is True
+        assert self.state().brightness == self.device.start_state["bright"]
+        assert self.state().reminder == (self.device.start_state["notifystatus"] == 'on')


line too long (89 > 79 characters)

houndci-bot · 2017-11-26T18:31:47Z

miio/tests/test_philips_bulb.py

+        self.device._reset_state()
+
+        assert self.is_on() is True
+


blank line at end of file

houndci-bot · 2017-11-26T18:31:47Z

miio/tests/test_ceil.py

+        self.device._reset_state()
+
+        assert self.is_on() is True
+


blank line at end of file

coveralls · 2017-11-26T18:34:57Z

Coverage increased (+5.1%) to 51.175% when pulling 73ec545 on syssi:feature/pytests-philipslights into fc9c4c6 on rytilahti:master.

houndci-bot · 2017-11-26T18:55:09Z

miio/tests/test_ceil.py

+        self.device.automatic_color_temperature_on()
+        assert automatic_color_temperature() == True
+        self.device.automatic_color_temperature_off()
+        assert automatic_color_temperature() == False


comparison to False should be 'if cond is False:' or 'if not cond:'
no newline at end of file

coveralls · 2017-11-26T18:57:55Z

Coverage increased (+6.5%) to 52.547% when pulling 49184f1 on syssi:feature/pytests-philipslights into fc9c4c6 on rytilahti:master.

houndci-bot · 2017-11-26T19:01:26Z

miio/tests/test_philips_bulb.py

+        assert scene() == 2
+
+
+


blank line at end of file

houndci-bot · 2017-11-26T19:01:26Z

miio/tests/test_philips_bulb.py

+        assert self.state().brightness == self.device.start_state["bright"]
+        assert self.state().color_temperature == self.device.start_state["cct"]
+        assert self.state().scene == self.device.start_state["snm"]
+        assert self.state().delay_off_countdown == self.device.start_state["dv"]


line too long (80 > 79 characters)

coveralls · 2017-11-26T19:04:12Z

Coverage increased (+6.3%) to 52.372% when pulling 2199a43 on syssi:feature/pytests-philipslights into fc9c4c6 on rytilahti:master.

rytilahti

Looks good in general. I added a couple of notes, in general we should be testing also for unexpected/invalid values from user.

rytilahti · 2017-11-26T19:07:21Z

miio/tests/test_ceil.py

+
+        assert self.is_on() is True
+        self.device.off()
+        assert self.is_on() is False


Considering quite a few devices has the ability for turning on and off, maybe it makes sense to have a single set of tests for all of those devices. For now this is fine though.

rytilahti · 2017-11-26T19:08:02Z

miio/tests/test_ceil.py

+        self.device.set_brightness(10)
+        assert brightness() == 10
+        self.device.set_brightness(20)
+        assert brightness() == 20


Test against incorrect values (brightness <0, >100), the bulbs should raise an exception if an incorrect value is thrown at them I think.

rytilahti · 2017-11-26T19:08:12Z

miio/tests/test_ceil.py

+        self.device.set_color_temperature(30)
+        assert color_temperature() == 30
+        self.device.set_color_temperature(20)
+        assert color_temperature() == 20


Same as above for incorrect values.

rytilahti · 2017-11-26T19:08:21Z

miio/tests/test_ceil.py

+        self.device.delay_off(100)
+        assert delay_off_countdown() == 100
+        self.device.delay_off(200)
+        assert delay_off_countdown() == 200


Same as above.

rytilahti · 2017-11-26T19:08:27Z

miio/tests/test_ceil.py

+        self.device.set_scene(1)
+        assert scene() == 1
+        self.device.set_scene(2)
+        assert scene() == 2


Same as above.

rytilahti · 2017-11-26T19:09:32Z

miio/tests/test_philips_bulb.py

+        self.device.set_brightness(10)
+        assert brightness() == 10
+        self.device.set_brightness(20)
+        assert brightness() == 20


Above comment on incorrect values. Merging with "brightness adjustable" could be done at some point?

rytilahti · 2017-11-26T19:09:43Z

miio/tests/test_philips_bulb.py

+        self.device.set_color_temperature(30)
+        assert color_temperature() == 30
+        self.device.set_color_temperature(20)
+        assert color_temperature() == 20


Test for incorrect inputs.

coveralls · 2017-11-26T19:17:39Z

Coverage increased (+6.3%) to 52.372% when pulling dd0fed8 on syssi:feature/pytests-philipslights into fc9c4c6 on rytilahti:master.

coveralls · 2017-11-26T19:41:44Z

Coverage increased (+7.3%) to 53.386% when pulling 8fd6e18 on syssi:feature/pytests-philipslights into fc9c4c6 on rytilahti:master.

coveralls · 2017-11-26T20:10:44Z

Coverage increased (+8.5%) to 54.558% when pulling 7987a87 on syssi:feature/pytests-philipslights into fc9c4c6 on rytilahti:master.

houndci-bot · 2017-11-26T20:30:22Z

miio/tests/test_philips_eyecare.py

+        assert self.state().eyecare is (self.device.start_state["eyecare"] == 'on')
+        assert self.state().scene == self.device.start_state["scene_num"]
+        assert self.state().smart_night_light is (self.device.start_state["bls"] == 'on')
+        assert self.state().delay_off_countdown == self.device.start_state["dvalue"]


line too long (84 > 79 characters)

houndci-bot · 2017-11-26T20:30:22Z

miio/tests/test_philips_eyecare.py

+        assert self.state().ambient_brightness == self.device.start_state["ambvalue"]
+        assert self.state().eyecare is (self.device.start_state["eyecare"] == 'on')
+        assert self.state().scene == self.device.start_state["scene_num"]
+        assert self.state().smart_night_light is (self.device.start_state["bls"] == 'on')


line too long (89 > 79 characters)

houndci-bot · 2017-11-26T20:30:22Z

miio/tests/test_philips_eyecare.py

+        assert self.state().reminder is (self.device.start_state["notifystatus"] == 'on')
+        assert self.state().ambient is (self.device.start_state["ambstatus"] == 'on')
+        assert self.state().ambient_brightness == self.device.start_state["ambvalue"]
+        assert self.state().eyecare is (self.device.start_state["eyecare"] == 'on')


line too long (83 > 79 characters)

houndci-bot · 2017-11-26T20:30:23Z

miio/tests/test_philips_eyecare.py

+        assert self.state().brightness == self.device.start_state["bright"]
+        assert self.state().reminder is (self.device.start_state["notifystatus"] == 'on')
+        assert self.state().ambient is (self.device.start_state["ambstatus"] == 'on')
+        assert self.state().ambient_brightness == self.device.start_state["ambvalue"]


line too long (85 > 79 characters)

houndci-bot · 2017-11-26T20:30:23Z

miio/tests/test_philips_eyecare.py

+
+        assert self.is_on() is True
+        assert self.state().brightness == self.device.start_state["bright"]
+        assert self.state().reminder is (self.device.start_state["notifystatus"] == 'on')


line too long (89 > 79 characters)

houndci-bot · 2017-11-26T20:30:23Z

miio/tests/test_ceil.py

+        assert self.state().scene == self.device.start_state["snm"]
+        assert self.state().delay_off_countdown == self.device.start_state["dv"]
+        assert self.state().smart_night_light is (self.device.start_state["bl"] == 1)
+        assert self.state().automatic_color_temperature is (self.device.start_state["ac"] == 1)


line too long (95 > 79 characters)

houndci-bot · 2017-11-26T20:30:23Z

miio/tests/test_ceil.py

+        assert self.state().color_temperature == self.device.start_state["cct"]
+        assert self.state().scene == self.device.start_state["snm"]
+        assert self.state().delay_off_countdown == self.device.start_state["dv"]
+        assert self.state().smart_night_light is (self.device.start_state["bl"] == 1)


line too long (85 > 79 characters)

houndci-bot · 2017-11-26T20:30:23Z

miio/tests/test_ceil.py

+        assert self.state().brightness == self.device.start_state["bright"]
+        assert self.state().color_temperature == self.device.start_state["cct"]
+        assert self.state().scene == self.device.start_state["snm"]
+        assert self.state().delay_off_countdown == self.device.start_state["dv"]


line too long (80 > 79 characters)

houndci-bot · 2017-11-26T20:30:23Z

miio/philips_eyecare.py

        """Set eyecare user scene."""
-        return self.send("set_user_scene", [num])
+        if number < 1 or number > 4:
+            raise PhilipsEyecareException("Invalid fixed scene number: %s" % number)


line too long (84 > 79 characters)

houndci-bot · 2017-11-26T20:30:23Z

miio/philips_bulb.py

+    def set_scene(self, number: int):
+        """Set scene number."""
+        if number < 1 or number > 4:
+            raise PhilipsBulbException("Invalid fixed scene number: %s" % number)


line too long (81 > 79 characters)

coveralls · 2017-11-26T20:32:42Z

Coverage increased (+8.5%) to 54.558% when pulling 0bf3dca on syssi:feature/pytests-philipslights into fc9c4c6 on rytilahti:master.

Unit tests for philip lights introduced.

73ec545

houndci-bot reviewed Nov 26, 2017

View reviewed changes

Unit tests for the Xiaomi Ceiling Lamp added.

49184f1

houndci-bot reviewed Nov 26, 2017

View reviewed changes

Unit tests for the Xiaomi Smart Light Bulb added.

2199a43

houndci-bot reviewed Nov 26, 2017

View reviewed changes

syssi changed the title ~~Unit tests for philip lights~~ Unit tests for philips lights Nov 26, 2017

rytilahti reviewed Nov 26, 2017

View reviewed changes

Missing remapping added.

dd0fed8

Missing test_ prefixes added.

8fd6e18

Proper handling and testing of the limits added.

7987a87

Some hound errors fixed.

0bf3dca

houndci-bot reviewed Nov 26, 2017

View reviewed changes

syssi merged commit 3df66fd into rytilahti:master Nov 26, 2017

Unit tests for philips lights #133

Unit tests for philips lights #133

Conversation

syssi commented Nov 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 26, 2017 • edited

Choose a reason for hiding this comment

coveralls commented Nov 26, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 26, 2017 • edited

rytilahti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 26, 2017 • edited

coveralls commented Nov 26, 2017 • edited

coveralls commented Nov 26, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 26, 2017 • edited

coveralls commented Nov 26, 2017 •

edited

coveralls commented Nov 26, 2017 •

edited

coveralls commented Nov 26, 2017 •

edited

coveralls commented Nov 26, 2017 •

edited

coveralls commented Nov 26, 2017 •

edited

coveralls commented Nov 26, 2017 •

edited

coveralls commented Nov 26, 2017 •

edited