Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Air Purifier 4 (zhimi.airp.mb5) #1357

Merged
merged 3 commits into from Mar 14, 2022

Conversation

MPThLee
Copy link
Contributor

@MPThLee MPThLee commented Mar 13, 2022

This fixes #1352
https://home.miot-spec.com/spec/zhimi.airp.mb5

VA2 code shares everything that python-miio needs.

miio/airpurifier_miot.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2022

Codecov Report

Merging #1357 (0e15ca1) into master (af1e31a) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #1357   +/-   ##
=======================================
  Coverage   82.17%   82.17%           
=======================================
  Files         109      109           
  Lines       11784    11784           
  Branches     1386     1386           
=======================================
  Hits         9683     9683           
  Misses       1893     1893           
  Partials      208      208           
Impacted Files Coverage Δ
miio/airpurifier_miot.py 83.08% <50.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MPThLee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported device Xiaomi Smart Air Purifier 4 (zhimi.airp.mb5)
4 participants