Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use devinfo.model for unsupported model warning #1359

Merged

Conversation

MPThLee
Copy link
Contributor

@MPThLee MPThLee commented Mar 14, 2022

Fixes #1358

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022

Codecov Report

Merging #1359 (a3629e4) into master (36568cb) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
- Coverage   82.17%   82.15%   -0.02%     
==========================================
  Files         109      109              
  Lines       11784    11784              
  Branches     1386     1386              
==========================================
- Hits         9683     9681       -2     
- Misses       1893     1894       +1     
- Partials      208      209       +1     
Impacted Files Coverage Δ
miio/device.py 54.36% <ø> (-1.35%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the PR! :-)

@rytilahti rytilahti added the bug label Mar 14, 2022
@rytilahti rytilahti merged commit 1c33b3f into rytilahti:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: --model overrides unsupported model warning
3 participants