Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require click8+ (API incompatibility on result_callback) #1378

Merged
merged 3 commits into from Apr 6, 2022
Merged

Require click8+ (API incompatibility on result_callback) #1378

merged 3 commits into from Apr 6, 2022

Conversation

Sir-Photch
Copy link
Contributor

Running mirobo with current pip3-package fails with:

Traceback (most recent call last):
  File "C:\Users\chris\scoop\apps\python\current\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Users\chris\scoop\apps\python\current\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\Users\chris\venv\Scripts\mirobo.exe\__main__.py", line 4, in <module>
  File "C:\Users\chris\venv\lib\site-packages\miio\integrations\vacuum\roborock\vacuum_cli.py", line 91, in <module>
    @cli.resultcallback()
AttributeError: 'ExceptionHandlerGroup' object has no attribute 'resultcallback'. Did you mean: 'result_callback'?

Changing the attribute as suggested by the error message resolves this error for me.

@Sir-Photch
Copy link
Contributor Author

(Under python 3.10.4)

@rytilahti
Copy link
Owner

This was renamed in pallets/click#1848 meaning that changing this is a breaking change and we need to depend on click8+. Mind adjusting the pyproject.toml accordingly and call poetry update and commit the changes?

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sir-Photch! 👍

@rytilahti rytilahti changed the title fixing AttributeError with result_callback Require click8+ (API incompatibility on result_callback) Apr 6, 2022
@rytilahti rytilahti merged commit a7adf5a into rytilahti:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants