Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak the communication when using construct v2.8.17 #142

Merged
merged 1 commit into from Dec 15, 2017

Conversation

rytilahti
Copy link
Owner

  • Removes usage of Enum (construct internals were changed, and this is the simplest way to fix it)
  • devtype and devserial are now just "device_id", as the values of those fields are not really known

Fixes checksum issue seen in home-assistant/core#11048 - related to construct/construct#416 .

* Removes usage of Enum (construct internals were changed, and this is the simplest way to fix it)
* devtype and devserial are now just "device_id", as the values of those fields are not really known
@coveralls
Copy link

coveralls commented Dec 13, 2017

Coverage Status

Coverage decreased (-0.003%) to 63.082% when pulling 1006443 on fix_protocol into 6ebbbbc on master.

@fanthos
Copy link
Contributor

fanthos commented Dec 14, 2017

I had the same problem when test my new device with Home Assistant.
Simply change "devtype" in protocol.py from Enum to Default fix the issue.
Combining devtype and serial should be a good idea.

@rytilahti
Copy link
Owner Author

Ok, thanks for testing, let's get this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants