Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify helper decorators to accept name as non-kwarg #1499

Merged
merged 1 commit into from Aug 14, 2022

Conversation

rytilahti
Copy link
Owner

It gets tiresome to write the always required name using kwarg for sensors and switches, this changes the decorator to allow passing it without doing that.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2022

Codecov Report

Merging #1499 (6af2de1) into master (cf90f2c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1499   +/-   ##
=======================================
  Coverage   82.59%   82.59%           
=======================================
  Files         142      142           
  Lines       14033    14033           
  Branches     3345     3345           
=======================================
  Hits        11591    11591           
  Misses       2222     2222           
  Partials      220      220           
Impacted Files Coverage Δ
miio/devicestatus.py 96.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit d9672f2 into master Aug 14, 2022
@rytilahti rytilahti deleted the fix/decorator_allow_nonkwarg_name branch August 14, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants