Allow custom methods for miio simulator #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow simulating devices that do use other methods besides "get_prop" for fetching the properties. Added simulated roborock s7 as an example case.
rytilahti
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1538 +/- ##
==========================================
- Coverage 81.95% 81.88% -0.07%
==========================================
Files 149 149
Lines 14594 14605 +11
Branches 3550 1660 -1890
==========================================
Hits 11960 11960
- Misses 2387 2398 +11
Partials 247 247
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@rytilahti I now also tested the embeded status container with a real vacuum, it seems to work, but there is some issue with the getatrributes see #1542 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow simulating devices that do use other methods besides "get_prop" for fetching the properties.
The result can be defined either as regular yaml object (
result) or as json string (result_json).Added simulated roborock s7 as an example case, looks like the status container embedding is working as expected (@starkillerOG):
