Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use __ as delimiter for embedded statuses #1573

Merged
merged 1 commit into from Nov 6, 2022

Conversation

rytilahti
Copy link
Owner

Leaves ":" free for other uses,
converts to use __getattr__ instead of __getattribute__ to avoid checking on every attribute access.

Leaves ":" free for other uses,
converts to use __getattr__ instead of __getattribute__ to avoid checking on every attribute access.
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

Merging #1573 (4045404) into master (34d3f0e) will decrease coverage by 0.02%.
The diff coverage is 32.14%.

@@            Coverage Diff             @@
##           master    #1573      +/-   ##
==========================================
- Coverage   81.06%   81.03%   -0.03%     
==========================================
  Files         155      155              
  Lines       15071    15079       +8     
  Branches     3250     3250              
==========================================
+ Hits        12217    12219       +2     
- Misses       2610     2615       +5     
- Partials      244      245       +1     
Impacted Files Coverage Δ
miio/devtools/pcapparser.py 0.00% <0.00%> (ø)
miio/click_common.py 53.62% <45.45%> (+0.94%) ⬆️
miio/devicestatus.py 90.41% <50.00%> (-2.74%) ⬇️
miio/miioprotocol.py 33.56% <50.00%> (+0.45%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti
Copy link
Owner Author

Ping @starkillerOG – looks like the previous implementation used wrong dunder method for accessing the custom attributes, this should fix the issues you had when you tried to use __ earlier in names in your PR.

@rytilahti rytilahti merged commit c15215b into master Nov 6, 2022
@rytilahti rytilahti deleted the fix/change_embedded_delimiter branch November 6, 2022 20:51
@starkillerOG
Copy link
Contributor

Thanks for looking into this, I will test this as soon as possible

@starkillerOG
Copy link
Contributor

@rytilahti I just tested it and it works as advertised, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants