Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting enum values, report on invalids in miotsimulator #1574

Merged
merged 1 commit into from Nov 6, 2022

Conversation

rytilahti
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

Merging #1574 (6eab046) into master (34d3f0e) will decrease coverage by 0.04%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master    #1574      +/-   ##
==========================================
- Coverage   81.06%   81.01%   -0.05%     
==========================================
  Files         155      155              
  Lines       15071    15085      +14     
  Branches     3250     3250              
==========================================
+ Hits        12217    12221       +4     
- Misses       2610     2620      +10     
  Partials      244      244              
Impacted Files Coverage Δ
miio/devtools/pcapparser.py 0.00% <0.00%> (ø)
miio/devtools/simulators/miotsimulator.py 0.00% <0.00%> (ø)
miio/click_common.py 53.62% <45.45%> (+0.94%) ⬆️
miio/miioprotocol.py 33.56% <50.00%> (+0.45%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti changed the title Fix setting enum values, report on invalid values in miotsimulator Fix setting enum values, report on invalids in miotsimulator Nov 6, 2022
@rytilahti rytilahti merged commit 4affa58 into master Nov 6, 2022
@rytilahti rytilahti deleted the fix/miotemulator_enums branch November 6, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants