Use __qualname__ to make ids unique for settings and sensors #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1589 +/- ##
=======================================
Coverage 80.88% 80.88%
=======================================
Files 156 156
Lines 15254 15256 +2
Branches 3283 3283
=======================================
+ Hits 12338 12340 +2
Misses 2667 2667
Partials 249 249
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Closed
rytilahti
changed the title
rytilahti
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
LGTM, I edited the title a bit 👍
@starkillerOG On those CI errors, I'm wondering if you are basing your branches on master that does not have #1565?
|
I schould be basing on the default https://github.com/rytilahti/python-miio/ (master) branch when I make new branches... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #1586
set the id to the qualified_name instead of only the function name (in order to prevent unique_id collisions in HomeAssistant for example with DNDStatus.start and CleaningDetails.start)