Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark "chuangmi.camera.021a04" as supported #1599

Merged
merged 4 commits into from Nov 21, 2022
Merged

Conversation

st7105
Copy link
Contributor

@st7105 st7105 commented Nov 18, 2022

Adding support for Chuangmi Model: https://home.miot-spec.com/s/chuangmi.camera.021a04

@rytilahti
Copy link
Owner

rytilahti commented Nov 19, 2022

Thanks for the PR @st7105! Have you verified that this device works with miiocli chuangmi_camera? I'm just wondering as the link you added describes the miot protocol for this device, while chuangmi_camera implements an older miio protocol that is not compatible with it.

@st7105
Copy link
Contributor Author

st7105 commented Nov 21, 2022

@rytilahti Yes.

miiocli chuangmicamera --ip *** --token *** info

WARNING:miio.device:Found an unsupported model 'chuangmi.camera.021a04' for class 'ChuangmiCamera'. If this is working for you, please open an issue at https://github.com/rytilahti/python-miio/

Model: chuangmi.camera.021a04
Hardware version: Linux
Firmware version: 4.3.4_0372

@rytilahti rytilahti changed the title Add "chuangmi.camera.021a04" support Mark "chuangmi.camera.021a04" as supported Nov 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2022

Codecov Report

Merging #1599 (cbe092c) into master (0db7997) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1599   +/-   ##
=======================================
  Coverage   80.88%   80.88%           
=======================================
  Files         157      157           
  Lines       15338    15338           
  Branches     3350     3350           
=======================================
  Hits        12406    12406           
  Misses       2676     2676           
  Partials      256      256           
Impacted Files Coverage Δ
miio/chuangmi_camera.py 70.85% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit 086bc8c into rytilahti:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants