Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded model information from mdns discovery #1695

Merged
merged 3 commits into from Jan 27, 2023

Conversation

rytilahti
Copy link
Owner

As the mdns name can be converted into a model name, there is no need to hardcode any of this information.

@codecov-commenter
Copy link

Codecov Report

Merging #1695 (30cc18f) into master (131a555) will decrease coverage by 0.44%.
The diff coverage is 25.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1695      +/-   ##
==========================================
- Coverage   80.04%   79.60%   -0.44%     
==========================================
  Files         161      161              
  Lines       16163    16149      -14     
  Branches     3645     3641       -4     
==========================================
- Hits        12937    12855      -82     
- Misses       2963     3015      +52     
- Partials      263      279      +16     
Impacted Files Coverage Δ
miio/devtools/simulators/miotsimulator.py 0.00% <0.00%> (ø)
miio/discovery.py 34.88% <20.83%> (-13.77%) ⬇️
miio/miot_models.py 63.63% <100.00%> (+0.64%) ⬆️
miio/alarmclock.py 0.00% <0.00%> (-69.15%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit d6b5fe8 into master Jan 27, 2023
@rytilahti rytilahti deleted the janitor/cleanup_mdns_discovery branch January 27, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants