Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SettingDescriptor's type to setting_type #1715

Merged
merged 4 commits into from Feb 6, 2023

Conversation

rytilahti
Copy link
Owner

This makes the type of 'type' consistent among all descriptors.

This makes the type of 'type' consistent among all descriptors.
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2023

Codecov Report

Merging #1715 (466ae9a) into master (7ad548a) will decrease coverage by 0.02%.
The diff coverage is 61.11%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1715      +/-   ##
==========================================
- Coverage   81.82%   81.81%   -0.02%     
==========================================
  Files         193      193              
  Lines       17987    17990       +3     
  Branches     3846     3847       +1     
==========================================
  Hits        14718    14718              
- Misses       2982     2984       +2     
- Partials      287      288       +1     
Impacted Files Coverage Δ
miio/miot_models.py 63.63% <ø> (ø)
miio/device.py 83.90% <25.00%> (-1.48%) ⬇️
miio/descriptors.py 96.36% <90.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit 39bf909 into master Feb 6, 2023
@rytilahti rytilahti deleted the fix/fix_genericmiot_bool_settings branch February 6, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants