Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor viomi cleanups #1742

Merged
merged 3 commits into from Feb 20, 2023
Merged

Minor viomi cleanups #1742

merged 3 commits into from Feb 20, 2023

Conversation

rytilahti
Copy link
Owner

@rytilahti rytilahti commented Feb 20, 2023

  • Move misplaced viomivacuum into viomi/vacuum
  • Disable unknown sensors
  • Unmark error to be a standard id, as it's not really used by homeassistant

@rytilahti rytilahti changed the title Move viomivacuum into viomi/vacuum, disable unknown sensors Minor viomi cleanups Feb 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Merging #1742 (b354ab9) into master (7bd3e34) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1742      +/-   ##
==========================================
- Coverage   81.91%   81.91%   -0.01%     
==========================================
  Files         196      196              
  Lines       18084    18081       -3     
  Branches     3862     3856       -6     
==========================================
- Hits        14814    14811       -3     
  Misses       2980     2980              
  Partials      290      290              
Impacted Files Coverage Δ
miio/integrations/viomi/vacuum/__init__.py 100.00% <ø> (ø)
miio/integrations/viomi/vacuum/viomivacuum.py 59.27% <83.33%> (ø)
miio/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit eca56e1 into master Feb 20, 2023
@rytilahti rytilahti deleted the janitor/viomi_cleanup branch February 20, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants