Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't log error message when decoding valid discovery packets #1832

Merged
merged 2 commits into from Oct 7, 2023
Merged

Don't log error message when decoding valid discovery packets #1832

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15f5dd4
Don't log error message when decoding valid discovery packets (#1824).
gunjambi Sep 24, 2023
d292d9d
Apply review feedback.
gunjambi Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions miio/protocol.py
View file
Open in desktop
Expand Up @@ -161,6 +161,9 @@ def _encode(self, obj, context, path):

def _decode(self, obj, context, path) -> Union[Dict, bytes]:
"""Decrypts the payload using the token stored in the context."""
# Missing payload is expected for discovery messages.
if not obj:
return obj
try:
decrypted = Utils.decrypt(obj, context["_"]["token"])
decrypted = decrypted.rstrip(b"\x00")
Expand Down