Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use call_action_from_mapping for existing miot integrations #1855

Merged
merged 1 commit into from Oct 23, 2023

Conversation

rytilahti
Copy link
Owner

Fixes regression caused by #1845 and missing tests for action calls on existing miot integrations.

Fixes #1854

@rytilahti rytilahti added the bug label Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #1855 (fba4d2e) into master (b25bf7c) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1855   +/-   ##
=======================================
  Coverage   81.40%   81.40%           
=======================================
  Files         193      193           
  Lines       18567    18567           
  Branches     4026     4026           
=======================================
  Hits        15115    15115           
  Misses       3171     3171           
  Partials      281      281           
Files Coverage Δ
miio/integrations/ijai/vacuum/pro2vacuum.py 96.89% <0.00%> (ø)
miio/integrations/mmgg/petwaterdispenser/device.py 70.68% <0.00%> (ø)
miio/integrations/mijia/vacuum/g1vacuum.py 73.07% <0.00%> (ø)
...io/integrations/roidmi/vacuum/roidmivacuum_miot.py 89.14% <0.00%> (ø)
...io/integrations/dreame/vacuum/dreamevacuum_miot.py 74.47% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit 4e2c5ee into master Oct 23, 2023
23 of 24 checks passed
@rytilahti rytilahti deleted the fix/miot_call_action_regression branch October 23, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to start clean, Dreame Vacuum (model: dreame.vacuum.mc1808)
1 participant