Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device.py (class Device): Add to method Device.send parametr "sid" fo… #632

Closed
wants to merge 1 commit into from

Conversation

igzero
Copy link

@igzero igzero commented Feb 18, 2020

…r to send a command to a child zigbee device connected to the XiaomiGateway
Consider adding an additional SID parameter to the Device.send method to allow you to communicate with child zigbee devices connected to the XiaomiGateway. This patch is applied by me in practice, tested, works. What can I see about in my project https://github.com/igzero/xiaomigateway

…r to send a command to a child zigbee device connected to the XiaomiGateway
@rytilahti
Copy link
Owner

Could you please rebase this on top of #470 as there is no need to have it on other devices?

@rytilahti
Copy link
Owner

rytilahti commented Mar 29, 2020

Replaced with a more generic #653, #651 adds support for the gateway class. Thanks for the PR anyway, @igzero!

Looks like your component add several new features that are not currently implemented in the Gateway class or its subdevices, do you have any plans to help get those integrated here? :-)

@rytilahti rytilahti closed this Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants