Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vacuum: Catch DeviceInfoUnavailableException for model detection #748

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

rytilahti
Copy link
Owner

This quick fix is required to avoid breaking the homeassistant integration, looks like my local setup was running an older version of the lib and that's why this was not spotted. I'll do a quick 0.5.2.1 release with this included.

@coveralls
Copy link

coveralls commented Jul 3, 2020

Coverage Status

Coverage remained the same at 73.942% when pulling 42fd08a on vacuum/fix/fanspeed_detection into 28d8d8a on master.

@rytilahti rytilahti merged commit 6078c15 into master Jul 3, 2020
@rytilahti rytilahti deleted the vacuum/fix/fanspeed_detection branch July 3, 2020 17:44
rytilahti added a commit that referenced this pull request Jul 3, 2020
[Full Changelog](0.5.2...0.5.2.1)

**Merged pull requests:**

- vacuum: Catch DeviceInfoUnavailableException for model detection [\#748](#748) ([rytilahti](https://github.com/rytilahti))
@rytilahti rytilahti mentioned this pull request Jul 3, 2020
rytilahti added a commit that referenced this pull request Jul 3, 2020
…ction. (#749)

[Full Changelog](0.5.2...0.5.2.1)

**Merged pull requests:**

- vacuum: Catch DeviceInfoUnavailableException for model detection [\#748](#748) ([rytilahti](https://github.com/rytilahti))
xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
…ction. (rytilahti#749)

[Full Changelog](rytilahti/python-miio@0.5.2...0.5.2.1)

**Merged pull requests:**

- vacuum: Catch DeviceInfoUnavailableException for model detection [\rytilahti#748](rytilahti#748) ([rytilahti](https://github.com/rytilahti))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants