Added some parameters: Error code, Viomimode, Viomibintype

[fs79]

added:

error codes
2103: "Charging",
2105: "Fully charged"

saw the 4 but don´t know what it means, but so no error message in cli command
class ViomiMode(Enum):
Unknown = 4

class ViomiBinType(Enum):
NoBin = 0

[coveralls]

Coverage increased (+0.007%) to 73.978% when pulling 5a3f2f4 on fs79:master into db2cb9c on rytilahti:master.

[rytilahti]

I think it would make more sense to add a log message(s) to the place(s) where the unknown mode is encountered, otherwise this looks good to go, thanks for the PR! 👍

[rytilahti]

Ping?

[titilambert]

I'm not sure I understand your comment, you mean a log message in the mode method ?
like here:

python-miio/miio/viomivacuum.py

Line 145 in 5a3f2f4

"""

?

[rytilahti]

I tried to say that it's more useful to simply log the unknown state on the call site, like done in

python-miio/miio/viomivacuum.py

Line 125 in 5a3f2f4

try:

-- in case someone is seeing those warnings in their logs and knows what causes them, they can create a PR to fix it.

[titilambert]

If @fs79 doesn't answer, I can integrate this patch in this PR (#808)

[syssi]

Mode 4 is something like CleanPosition.

[titilambert]

I confirm this message, I have the same one
Thanks !

[fs79]

I‘m fine with logging the unknown state.
It’s important that the unknown state doesn’t destroy the output of the cli command.
Im using the output and if there’s an issue due to unknown parameters it‘s an issue.

Would you do it in general for unknown states in all the outputs or only for the above mentioned vacuum/mop/... state?

[rytilahti]

Yes, I think it makes sense to log all unknown cases to avoid potential exceptions. Btw, if you want to parse the command line output, you may be interested in checking out the --output flag.

[fs79]

@rytilahti
You mean the "-o" flag?
Yes, I´m using it vor type vacuum but for viomivacuum it's not possible to use this flag.

[rytilahti]

Yeah, I think -o is the shortcut for that flag, which should definitely be available (and working) on all devices, so it must be a bug that can be fixed. Please feel free to create a separate issue / debug that / create a PR to fix the issue.

[fs79]

Issue for the -o json_pretty issue with viomivacuum cleaner.
#816