Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add consumable status to viomi vacuum #805

Merged
merged 3 commits into from
Sep 1, 2020
Merged

Add consumable status to viomi vacuum #805

merged 3 commits into from
Sep 1, 2020

Conversation

titilambert
Copy link
Contributor

Tested with:
Model: viomi.vacuum.v7
Hardware version: Linux
Firmware version: 3.5.3_0047

@coveralls
Copy link

coveralls commented Aug 29, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 73.944% when pulling f09b76e on titilambert:master into 425efb3 on rytilahti:master.

rytilahti
rytilahti approved these changes Aug 30, 2020
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the PR! 👍 This can be merged after the checks are passing.

@titilambert
Copy link
Contributor Author

@rytilahti I fixed the tests in my changes, but the tests are broken in master. What should I do ?

@rytilahti
Copy link
Owner

@titilambert oops, I didn't notice prior merging that the lastly merged PR broke linting.. I think the best way to proceed is to incorporate the linting fixes to this PR, so please run tox -e lint locally and add the modified files to this PR, thanks!

@rytilahti rytilahti mentioned this pull request Aug 31, 2020
Closed
@titilambert
Copy link
Contributor Author

titilambert commented Sep 1, 2020 •
edited
Loading

@titilambert oops, I didn't notice prior merging that the lastly merged PR broke linting.. I think the best way to proceed is to incorporate the linting fixes to this PR, so please run tox -e lint locally and add the modified files to this PR, thanks!

OK ! I just fixed the lint, the code coverage decreased, is it fine ?

@rytilahti
Copy link
Owner

Decrease in code coverage is not that big issue, although it'd be great to have tests for these parts. Let's get this merged so that the PR I linked can be rebased on top of this, thanks again for the PR!

@rytilahti rytilahti merged commit 93b7a77 into rytilahti:master Sep 1, 2020
xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
@titilambert @xvlady
Add consumable status to viomi vacuum (rytilahti#805)
0818297 
* Add consumable status to viomi

* Fix Lint

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti rytilahti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@titilambert @coveralls @rytilahti