Initial support for HUIZUO PISCES For Bedroom #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syssi
reviewed
Nov 25, 2020
2. Changing "color_temp" instead of "level" during manipulation with color temperature
rytilahti
reviewed
Nov 25, 2020
miio/huizuo.py
Outdated
|
|
||
| class HuizuoStatus: | ||
| def __init__(self, data): | ||
| # power = '{"siid":2,"piid":1}' values = true,false |
There was a problem hiding this comment.
Could you add the complete response payload (miiocli -d) here for future reference?
There was a problem hiding this comment.
Added in the file as comments (is this what you asked for? ;))
There was a problem hiding this comment.
Ah, sorry, just the json payload please, here's a good example: https://github.com/rytilahti/python-miio/blob/master/miio/airdehumidifier.py#L59
There was a problem hiding this comment.
Got it.
Updated by example
rytilahti
reviewed
Nov 25, 2020
Updated README. With the tests I have some troubles, can't get glue how to make it work, even test_get_status method. |
syssi
reviewed
Nov 26, 2020
syssi
reviewed
Nov 27, 2020
syssi
reviewed
Nov 27, 2020
syssi
reviewed
Nov 27, 2020
syssi
reviewed
Nov 27, 2020
syssi
reviewed
Nov 27, 2020
syssi
reviewed
Nov 27, 2020
syssi
reviewed
Nov 27, 2020
Merged
xvlady
pushed a commit
to xvlady/python-miio
that referenced
this pull request
May 9, 2021
* Adding Huizuo basic support * Add huizuo.py to the repo * Update __init__.py to the latest version * Fix _LOGGER error * Enabling iSort in VSCode on Save * 1. Removed unnecessary click.argument calls 2. Changing "color_temp" instead of "level" during manipulation with color temperature * 1. Removed Huizuo from discovery - devices are not mdns discoverable 2. Updated based on PR#868 * Re-arranged color_temp parameter for better understanding * fixing linting issues * Added only example of JSON payload from the lamp * Updated README.rst, added separations * 1. Use MiotDevice class 2. Add tests * Fixing linting issues * Fixing linting issue - second try... * Processing comments from PR#868
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have such a lamp and wrote the basic library to support it. Please review.