Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only call get_available_playback_functions() for version 1.2 #145

Merged

Conversation

allistermaguire
Copy link
Contributor

Fixes #144

I should have probably done it like this in the first place, calling get_available_playback_functions() is only necessary for method version 1.2 of getCurrentExternalTerminalsStatus to determine which terminal is active. I just assumed by looking through the devinfo's that it is supported by all devices and so thought it better to be the default.

I have tested with a STR-AN1000 which uses version 1.2, and @RobertBuhren has tested that it is working with an SRS-X77 which uses version 1.0.

@RobertBuhren
Copy link

Can this be merged and a new version of python-soundpal be released? This would fix my speaker control in HomeAssistant which is currently broken :)

@allistermaguire
Copy link
Contributor Author

Hi @RobertBuhren, maybe @rytilahti missed it.

pip3 install git+https://github.com/allistermaguire/python-songpal.git@0.16.1

If you don't want to wait you can uninstall the old version and install a fixed version from my repo, but before restarting Hass update the version in /usr/src/homeassistant/homeassistant/components/songpal/manifest.json (assuming this is where you have it installed).

home assistant can also be launched with --skip-pip to instruct it not to use pip to download and install the dependencies.

Note, that whenever you upgrade Hass, you will need to repeat the process.

@rytilahti rytilahti added the bug label Jan 22, 2024
@rytilahti
Copy link
Owner

rytilahti commented Jan 22, 2024

Thanks for the PR @allistermaguire! Looks good to me & thanks for the reminder, I've been quite busy the past weeks and completely forgot about this... I'll prepare a new release ASAP and bump the homeassistant version, so that it'll get to the 2024.2 release.

@rytilahti rytilahti merged commit 8fb3f21 into rytilahti:master Jan 22, 2024
4 checks passed
@rytilahti
Copy link
Owner

@allistermaguire
Copy link
Contributor Author

No problem. Thanks @rytilahti.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

https://github.com/rytilahti/python-songpal/pull/132 breaks support for SRS-X77
3 participants