Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update because async_upnp_client changed "discover" to "search" #41

Merged
merged 4 commits into from Feb 9, 2019
Merged

Update because async_upnp_client changed "discover" to "search" #41

merged 4 commits into from Feb 9, 2019

Conversation

jwiese
Copy link
Contributor

@jwiese jwiese commented Feb 5, 2019

No description provided.

rytilahti
rytilahti reviewed Feb 9, 2019
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you please keep changes to different parts in separate PRs, and create a second PR for the zone changes?

README.rst Outdated Show resolved Hide resolved
@jwiese
Copy link
Contributor Author

jwiese commented Feb 9, 2019

Ah, good catch, that was an accident, I split that out now

rytilahti
rytilahti approved these changes Feb 9, 2019
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works great!

@rytilahti rytilahti merged commit 42c5c4e into rytilahti:master Feb 9, 2019
@rytilahti rytilahti mentioned this pull request Feb 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti rytilahti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jwiese @rytilahti