Merge pull request #57 from mvaneerde/carriage-return

Add quotes if a field contains a carriage return \r even if it doesn't contain a line feed \n
ryu1kn · Nov 14, 2020 · 907e616 · 907e616
2 parents c635d2b + d71f3f7
commit 907e616
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/lib/field-stringifier.ts b/src/lib/field-stringifier.ts
@@ -25,7 +25,7 @@ class DefaultFieldStringifier extends FieldStringifier {
     }
 
     private needsQuote(str: string): boolean {
-        return str.includes(this.fieldDelimiter) || str.includes('\n') || str.includes('"')
+        return str.includes(this.fieldDelimiter) || str.includes('\r') || str.includes('\n') || str.includes('"')
     }
 }
 

diff --git a/src/test/field-stringifier.test.ts b/src/test/field-stringifier.test.ts
@@ -45,10 +45,18 @@ describe('DefaultFieldStringifier', () => {
                 strictEqual(stringifier.stringify(`VALUE${delim}A`), `"VALUE${delim}A"`)
             })
 
-            it('wraps a field value with double quotes if the field contains newline', () => {
+            it('wraps a field value with double quotes if the field contains carriage return', () => {
+                strictEqual(stringifier.stringify('VALUE\rA'), '"VALUE\rA"')
+            })
+
+            it('wraps a field value with double quotes if the field contains line feed', () => {
                 strictEqual(stringifier.stringify('VALUE\nA'), '"VALUE\nA"')
             })
 
+            it('wraps a field value with double quotes if the field contains carriage return and line feed', () => {
+                strictEqual(stringifier.stringify('VALUE\r\nA'), '"VALUE\r\nA"')
+            })
+
             it('wraps a field value with double quotes and escape the double quotes if they are used in the field', () => {
                 strictEqual(stringifier.stringify('VALUE"A'), '"VALUE""A"')
             })