-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added optional delimiters #8
Conversation
Hi @HKskn , thank you for taking time to contribute to the project! but I've got a different idea on supporting other delimiters. The current I've started thinking to support TSV (even this library is named |
Hi @ryu1kn, you are right. In my case, csv files formatted with delimiter ',' can't fit columns correctly on excel. It needs to use delimiter ';'. I think restricting delimiters is not good, there can be another delimiters. Thanks. |
Do you mean the CSV file generated by It's also interesting that if you use |
Ok, I found that, on Windows, depending on the "Regional and Language Options" settings, Excel assumes different characters for the field delimiter...
Seems we do need to support |
As far as i can see from a quick play around with Excel on windows with So I’m going to merge your PR and continue work on it before i release the next version. |
Merged! I'll let you know once I release the new version 👍 |
Released as v1.1.0. Thank you again for your contribution!! |
I think it needs optional delimiters.