-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.3.2 #63
Merged
Merged
Release 0.3.2 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced instances of ConfigParser with RawConfigParser to allow users with special characters in their password to successfully authenticate
* sphinx and sphinx_rtd_theme should be used to generate docs/ * pandoc should be used to publish package on PyPI (I use to markdown -> rst parsing)
Now the docs can be at least readable.
This can be useful to users check which version of mal they got installed.
Use RawConfigParser instead of ConfigParser
But we have a problem, this only fix for new users of this mal command line package. Old users should fix it your own config file about date_format interpolation %. If the user try execute using the old configuration with double % nothing will broken, but when someone try execute `mal list --extend` the date form will not show as expected.
Removed permissions: * __init__.py * commands.py This just doesn't makes any sense. However the permission execution for cli.py (which can be executed) was keep.
248be33
to
e8816b6
Compare
Maybe the package in this old versions of python still works, but I'm not developing thinking about it. The travis checkers only test for 3.4, 3.5 and 3.6.
Because this requirements is only to build documentation.
The new documentation can be accessed here: http://mal.readthedocs.io/en/release-0.3.2/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mal.__version__
variable.Side effects
After added the RawConfigParser we have a little problem here. The old configuration of the users use double interpolation of
%%
to date_format. I change the new template for when create new ones, create it right (using only one %). But old config files this will not touch. The result is:So old users of this program should fix your own config file manually with
date_format = %d-%m-%Y
when start using the version 0.3.2.This PR should close #4, close #3 and fix #61