Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.3.2 #63

Merged
merged 15 commits into from
Sep 9, 2017
Merged

Release 0.3.2 #63

merged 15 commits into from
Sep 9, 2017

Conversation

ryukinix
Copy link
Owner

@ryukinix ryukinix commented Sep 8, 2017

Summary

  • Use RawConfigParser instead of ConfigParser for configuration
  • Add version -v and --version flags
  • Remove support for watch and download commands
  • Add basic documentation on docs/source/index.rst from README.md (used pandoc)
  • Add requirements-dev.txt to build packages and docs
  • Setup ReadTheDocs on docs/ and integrate with mal package to fetch the new version from mal.__version__ variable.

Side effects

After added the RawConfigParser we have a little problem here. The old configuration of the users use double interpolation of %% to date_format. I change the new template for when create new ones, create it right (using only one %). But old config files this will not touch. The result is:

(env) ❯ mal config
File on: /home/lerax/.config/mal/myanimelist.ini
[config]
date_format = %%d-%%m-%%Y

[login]
username = lerax
password = SUPER-FUCKING-FUCKED-SECRET-PASSWORD

(env) ❯ mal filter 'tex.*' --extend
Matched 1 items:
1: Texhnolyze
   Completed at 22/22 episodes with score 7 
   Started: %d-%m-%Y 	 Finished: %d-%m-%Y
   Tags: None 

So old users of this program should fix your own config file manually with date_format = %d-%m-%Y when start using the version 0.3.2.

This PR should close #4, close #3 and fix #61

evanjs and others added 9 commits September 7, 2017 15:44
Replaced instances of ConfigParser with RawConfigParser to allow users
with special characters in their password to successfully authenticate
* sphinx and sphinx_rtd_theme should be used to generate docs/
* pandoc should be used to publish package on PyPI (I use to markdown
  -> rst parsing)
This can be useful to users check which version of mal they got
installed.
Use RawConfigParser instead of ConfigParser
But we have a problem, this only fix for new users of this mal command
line package. Old users should fix it your own config file about
date_format interpolation %. If the user try execute using the old
configuration with double % nothing will broken, but when someone
try execute `mal list --extend` the date form will not show as expected.
Removed permissions:
* __init__.py
* commands.py

This just doesn't makes any sense. However the permission execution
for cli.py (which can be executed) was keep.
@ryukinix ryukinix force-pushed the release-0.3.2 branch 2 times, most recently from 248be33 to e8816b6 Compare September 9, 2017 00:28
Maybe the package in this old versions of python still works,
but I'm not developing thinking about it. The travis checkers
only test for 3.4, 3.5 and 3.6.
Because this requirements is only to build documentation.
@ryukinix
Copy link
Owner Author

ryukinix commented Sep 9, 2017

The new documentation can be accessed here: http://mal.readthedocs.io/en/release-0.3.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add subcommand watch Add subcommand download
2 participants