Adding a before callback to the .retry_on feature

[ryz310]

For example, if an error occurs such as an access token expiring, it is useful to be able to regenerate the access token before retry processing. The current .retry_on feature is only useful in limited cases, but adding a before callback would be an enhancement.

[ryz310]

I came up with following code. I think it would be worked as a before callback.

class ExampleApiClient < MyApiClient::Base
  endpoint 'https://example.com'

  # 1. Detects an error
  error_handling json: { '$.errors.code': 10 }, with: :access_token_expired

  # 3. Retry with updated access token
  retry_on AccessTokenExpired, wait: 1.second, attempts: 1

  private

  # 2. Refresh access token before raising exception
  def access_token_expired(params, logger)
    refresh_access_token!
    raise AccessTokenExpired, params
  end
end

[ryz310]

#48 (comment)

Maybe it doesn't work as expected because it executes Exceptions#call in the Exceptions#call like as nested. I think it needs stack structure for arguments of #call calling.

my_api_client/lib/my_api_client/exceptions.rb

Lines 13 to 21 in 032d3d2

	def call(*args)
	@args = args
	send(*args)
	rescue StandardError => e
	@retry_count ||= 0
	raise unless rescue_with_handler(e)
	retry_result
	end