Added very basic interaction deferral check #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually when passed a deferred reply, this'll just throw an error saying it's already been deferred. So this should try editing the reply instead in the case that the try clause encounters a deferred reply.
|
What about using |
|
That's a good idea actually, I forgot that existed |
|
hmm well, can you edit it in and then commit the changes. I'll then merge the pr |
|
Not sure if what I just did was what you meant, if not it might be better for you to add the change just to save time since I'm no expert |
|
Yeah a few issues, imma fix it no worries. Thanks for ur efforts tho :) |
|
No worries, I'll close this pull then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually when passed a deferred reply, this'll just throw an error saying it's already been deferred. So this should try editing the reply instead in the case that the try clause encounters a deferred reply. Edit this to your desire, this is just how I'd approach adding the support.