Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript support #19

Closed
wants to merge 1 commit into from
Closed

Conversation

jben7
Copy link

@jben7 jben7 commented Sep 27, 2021

No description provided.

@ryzyx
Copy link
Owner

ryzyx commented Sep 28, 2021

Why ts support though, can't u use just the javascript package. I am not familiar with TS a lot as of yet, I'd need someone to review it or i need to opt for an alternate method

@jben7
Copy link
Author

jben7 commented Sep 28, 2021

TypeScript is better for safety, I let you know more about it, it's better for the future of this project.
Sorry for my bad english, I'm french ;)

@ryzyx
Copy link
Owner

ryzyx commented Sep 29, 2021

Once i get someone to review this PR and test it and make sure there is no problem. This will be merged. As of now I am closing this PR.

@ryzyx ryzyx closed this Sep 29, 2021
@kernelwernel
Copy link

@ryzyx I scrolled through and tested the PR, it works as intended. Also, you shouldn't limit your own package user audience to only javascript users. It's far better to add support for typescript when it has many features that javascript doesn't have.

@ryzyx
Copy link
Owner

ryzyx commented Feb 4, 2022

Man sure, I'd love to add Typescript support but I do not know Typescript well enough yet. Also I'll need to update 3 versions which are msg, interactions and ts. It'll become complicated for users. Whenever there'll be some changes in the TS version. I wont be able to do it. I can rely on someone to hopefully create a PR and fix it. Hope u understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants