Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get32IntFromBuffer to handle arbitary sizes #162

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

nanov
Copy link
Contributor

@nanov nanov commented Oct 30, 2019

As we know the size for fact, and in some cases ( exponent bigger than 65537 ) the current buffer method readUInt32BE gives unexpected results, it is better to utilise the more general readUIntBE buffer function combined with size in order to get the right results.

@nanov
Copy link
Contributor Author

nanov commented Oct 31, 2019

I have no idea why travis is in yellow mode, but looking into it it seems as the tests have completed successfully.

@rzcoder rzcoder merged commit a6a1952 into rzcoder:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants