Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP integration #95

Merged
merged 36 commits into from
Sep 23, 2023
Merged

LSP integration #95

merged 36 commits into from
Sep 23, 2023

Conversation

aabounegm
Copy link
Member

Along with rzk-lang/vscode-rzk#36.
Adds a simple implementation of a language server using LSP, currently with semantic tokens and error reporting (for parsing and type errors).

@aabounegm aabounegm mentioned this pull request Sep 22, 2023
Closed
@aabounegm
Copy link
Member Author

And as always whenever I add a new dependency, seems like I need help with the Nix configuration :D

@fizruk
Copy link
Member

fizruk commented Sep 23, 2023

@deemp do you know why 14b45ea did not work? can you help fix this?

@deemp
Copy link
Contributor

deemp commented Sep 23, 2023

#82 (comment)

It doesn't use rzk.nix

Sorry, it was false. You can write hpack --force in rzk.nix. At least this is how I fixed a build error in #84

aabounegm and others added 23 commits September 23, 2023 16:37
@aabounegm @fizruk
Add lsp and lsp-types to dependencies
17ce500
@aabounegm @fizruk
Replace VSToken with lsp's SemanticTokeType
ee1ef42
@aabounegm @fizruk
Add minimal LSP handler for semantic token request
7410f42
@aabounegm @fizruk
Add a hover handler for testing purposes
0663be5
@aabounegm @fizruk
Replace the tokenize command with LSP
d611c7f
@aabounegm @fizruk
Define the server's document sync options
111f6fb
@aabounegm @fizruk
Implement the semantic tokenization handler
9dad694
@aabounegm @fizruk
Add empty handlers to silence errors
b944ee1 
For the didOpen, didChange, and didClose events
@aabounegm @fizruk
Add an empty handler for TextDocumentDidSave
2b9bbb7 
to silence another false error
@aabounegm @fizruk
Disable the hover handler temporarily
3f2936e
@aabounegm @fizruk
Implement displaying error messages as diagnostics
c099cc7
@aabounegm @fizruk
Request including the text in save events
d5bd474
@aabounegm @fizruk
Add an empty handler for "didChangeWatchedFiles"
60e1bc1
@aabounegm @fizruk
Run the autoformatter
ce46be0
@aabounegm @fizruk
Simplify getting the text in "didSave" handler
d0230e0
@aabounegm @fizruk
Add the filepath package for processing paths
dc0b456
@aabounegm @fizruk
Define a Yaml schema for our config file
17ccc49
@aabounegm @fizruk
Add a handler for typechecking all files in config
aa54544 
Currently used on extension initialization, whenever rzk.yaml
is changed, and whenever any open file is saved
@fizruk
Use cabal2nix --compiler ghcjs to generate rzk.nix for GHCJS
346f230
@fizruk
Try using callCabal2nix in try-rzk/default.nix instead
3d1aba9
@fizruk
Remove rzk.nix
5d2f34f
@fizruk
Revert back to calling cabal2nix from the workflow
02e500a
@fizruk
Add rzk.nix back (generated manually via cabal2nix --compiler ghcjs)
e71f48b
fizruk
fizruk approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@fizruk fizruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works marvellously on my machine!

@fizruk fizruk merged commit 487321f into develop Sep 23, 2023
2 checks passed
@fizruk fizruk deleted the lsp branch September 23, 2023 17:36
@fizruk fizruk mentioned this pull request Sep 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fizruk fizruk fizruk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aabounegm @fizruk @deemp