Auto-format all files #142
Conversation
|
Awesome! I will take the time to review this later this week. |
There was a problem hiding this comment.
Okay, I've reviewed about half the files now and pointed out different issues I saw. Although the autoformatter isn't perfect yet, I think it is a great improvement over no autoformatter, and so would be happy to have it deployed even in its current revision. Thanks for taking the initiative on this! And let me know if/when you want further input :)
|
@fredrik-bakke Thank you very much for the constructive feedback! I hope that most of the issues have been addressed now. It seems to me that the remaining unresolved conversations are about either inserting line breaks or fixing indentation, both of which are planned for the future as they are not straightforward to implement with the current architecture (opened issues rzk-lang/rzk#147 and rzk-lang/rzk#148). |
This PR runs the new auto-formatter for Rzk that implements the style guide. It is currently still under work in rzk-lang/rzk#144, so before it is merged and released, I'd like to make sure that it works as expected, so I ran it on all files in this project (using
rzk format --write). This should help find implementation mistakes in the formatter and/or inconsistencies in the style guide (the hopeful best-case scenario would be that it aligns all formalizations with the current style guide 🙂).Please review these changes and point out any problems or possible improvements.