Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix permissions for autoformat workflow #96

Merged
merged 7 commits into from
Oct 8, 2023
Merged

Fix permissions for autoformat workflow #96

merged 7 commits into from
Oct 8, 2023

Conversation

fredrik-bakke
Copy link
Contributor

No description provided.

@fredrik-bakke fredrik-bakke mentioned this pull request Oct 8, 2023
Merged
@fredrik-bakke fredrik-bakke added the bug Something isn't working label Oct 8, 2023
@fizruk
Copy link
Member

fizruk commented Oct 8, 2023

I don't see any re-formatted files after the CI run. Does this mean we already have everything well-formatted?

@fizruk
Copy link
Member

fizruk commented Oct 8, 2023

I see, it sort of worked :)

@fredrik-bakke
Copy link
Contributor Author

I'm suspicious that the reason my test didn't work is because the autoformatting would result in an empty commit.

@fredrik-bakke
Copy link
Contributor Author

yep

@fredrik-bakke
Copy link
Contributor Author

In practice that should never happen when we merge into main, but I'll see if I can fix it

fizruk
fizruk previously approved these changes Oct 8, 2023
View reviewed changes
@fizruk
Copy link
Member

fizruk commented Oct 8, 2023

Looks good to me as it is, I think we can merge.

@fredrik-bakke fredrik-bakke marked this pull request as ready for review October 8, 2023 15:46
@fredrik-bakke
Copy link
Contributor Author

RIght, sorry, I fixed the empty commit issue now though. Would you mind approving it again?

@fredrik-bakke fredrik-bakke merged commit fd31a55 into main Oct 8, 2023
1 check passed
@fredrik-bakke fredrik-bakke deleted the ci-format branch October 8, 2023 18:26
@fredrik-bakke
Copy link
Contributor Author

I don't see any re-formatted files after the CI run. Does this mean we already have everything well-formatted?

Ah, sorry, I didn't see your question before. The autoformatter only formats files that are changed by the commit. Since I'm not committing any ill-formatted files, it is not changing any files at the moment.

github-actions bot pushed a commit to StiephenPradal/sHoTT that referenced this pull request Oct 9, 2023
@fredrik-bakke @actions-user
Merge pull request rzk-lang#96 from rzk-lang/ci-format
0aa71f3 
Fix permissions for autoformat workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fizruk fizruk fizruk approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fredrik-bakke @fizruk