Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sendgrid message id to transport & support laravel 10 #166

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

parkourben99
Copy link
Contributor

WHAT

Added X-Sendgird-Message-ID to the header of the email.

WHY

This was in the previous version for laravel 8. It also provides a way to match emails from incoming webhooks using the message id.

Copy link

@tomcodes tomcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@parkourben99 parkourben99 changed the title Add sendgrid message id to transport Add sendgrid message id to transport & support laravel 10 Feb 15, 2023
Copy link
Contributor

@felipehertzer felipehertzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@parkourben99
Copy link
Contributor Author

@s-ichikawa Are you able to review this please.

@s-ichikawa s-ichikawa merged commit a86f8f5 into s-ichikawa:master Feb 15, 2023
@s-ichikawa
Copy link
Owner

@parkourben99 merged! thank you for your contribution!

@jameswagoner
Copy link

@parkourben99 Curious to know how you utilized the message ID when you are sending mailables.

@parkourben99
Copy link
Contributor Author

@parkourben99 Curious to know how you utilized the message ID when you are sending mailables.

@jameswagoner You can use this ID to match with the activity webhooks for open, bounce, etc.

@jameswagoner
Copy link

jameswagoner commented May 24, 2024 via email

@parkourben99
Copy link
Contributor Author

Using the SentMessage event taking the x-sendgrid-message-id header and matching it with the sg_message_id on webhook payloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants