-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
having terminal in non canvas / request animation frame in firefox 24 #67
Comments
Hi trabitboy |
I tried the current jor1k with Firefox 24 portable. Works without problems. |
Tomorrow first thing, I am back on more recent FF for tonight :)
|
sorry for incorrect report, [09:27:59.467] TypeError: window.requestAnimationFrame is not a function @ http://s-macke.github.io/jor1k/bin/jor1k-master-min.js:1034 |
you were right terminal version also blows up on request animation frame but this seems to run so must use a slightly different / alternative api : |
no it gives an error too :) |
Hi , I'll try to do a conditional lookup for |
Can you try the following link? |
It works ! On 7 May 2015 at 11:16, Sebastian Macke notifications@github.com wrote:
|
I removed the function requestanimationframe. Normally I wouldn't remove a feature just to support an old web browser. But the function call was never necessary and the patch makes the code easier to understand. |
I have been trying to test from a place where the browser is locked to firefox 24, which normally supports requestAnimationFrame() but gives an error with the exact signature used in tty refresh.
Browsing the code I saw there is alternate/ legacy implementation that renders to a table,
depending on the item type in the dom ; is it still supported ? is there an alternate index.html to try it .
Putting a small requestAnimationFrame test on my browser together, this api turns my brain around.
The text was updated successfully, but these errors were encountered: