Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modualize terminals, pluginize terminal emulator, add term.js #48

Merged
merged 1 commit into from
Jan 9, 2015
Merged

Modualize terminals, pluginize terminal emulator, add term.js #48

merged 1 commit into from
Jan 9, 2015

Conversation

ysangkok
Copy link
Collaborator

@ysangkok ysangkok commented Jan 9, 2015

This improved upon pull request #47 with the proposed changes and also handles Unicode correctly. It addresses issue #46 .

It still requires patched term.js with the following patch:

diff --git a/src/term.js b/src/term.js
index f26617d..c061e36 100644
--- a/src/term.js
+++ b/src/term.js
@@ -464,9 +464,9 @@ Terminal.prototype.initGlobal = function() {
   }
   Terminal._boundDocs.push(document);

-  Terminal.bindPaste(document);
+  //Terminal.bindPaste(document);

-  Terminal.bindKeys(document);
+  //Terminal.bindKeys(document);

   Terminal.bindCopy(document);

@ysangkok ysangkok mentioned this pull request Jan 9, 2015
s-macke added a commit that referenced this pull request Jan 9, 2015
…-support

Modualize terminals, pluginize terminal emulator, add term.js
@s-macke s-macke merged commit 32a20fa into s-macke:master Jan 9, 2015
@s-macke
Copy link
Owner

s-macke commented Jan 9, 2015

Accepted, but I might change a lot to prevent further chaos.

@ysangkok ysangkok deleted the modularized-terminals-and-termjs-support branch January 9, 2015 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants